On 01/24/11 18:28, Stefan Weil wrote: > There was some discussion regarding this patch set. > I agree with Markus that part of the first patch > should be removed: don't change char to unsigned char.
The unsigned char should definitely go in, leaving it as a signed char doesn't serve any purpose. > It's not necessary, and the result is, that now unsigned chars > are assigned to chars which might raise future compiler > warnings. We already do that cast by calling qemu_toupper() and qemu_isspace() so that argument is void. Jes
