On 04/23/2018 02:34 PM, Richard Henderson wrote: > On 04/23/2018 06:25 AM, Philippe Mathieu-Daudé wrote: >> Assuming the base of the fdt is aligned, a 32-bit property returns >> a 32-bit aligned pointer... > ... >> case 4: >> - *addr = fdt32_to_cpu(*(fdt32_t *)prop); >> + *addr = fdt32_to_cpu(ldl_he_p(prop)); >> return 0; > > So why are you changing the 32-bit case?
First to not assume base fdt is always 32-bit aligned, second to keep calls similar and avoid someone use *(fdt64_t *) similar to the 32-bit property. But this is avoidable with a simple comment about why we have to use ldq_he_p().
