On 04/20/2018 02:48 PM, Peter Maydell wrote: > Currently we use memory_region_init_ram_nomigrate() to create > the "aspeed.boot_rom" memory region, and we don't manually > register it with vmstate_register_ram(). This currently > means that its contents are migrated but as a ram block > whose name is the empty string; in future it may mean they > are not migrated at all. Use memory_region_init_ram() instead. > > Note that this is a cross-version migration compatibility break > for the "palmetto-bmc", "ast2500-evb" and "romulus-bmc" machines.
Migration does not work for these. > Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> Reviewed-by: Cédric Le Goater <c...@kaod.org> Tested-by: Cédric Le Goater <c...@kaod.org> On palmetto, romulus and ast2500-evb boards Thanks C. > --- > hw/arm/aspeed.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c > index 7088c907bd..aecb3c1e75 100644 > --- a/hw/arm/aspeed.c > +++ b/hw/arm/aspeed.c > @@ -225,7 +225,7 @@ static void aspeed_board_init(MachineState *machine, > * SoC and 128MB for the AST2500 SoC, which is twice as big as > * needed by the flash modules of the Aspeed machines. > */ > - memory_region_init_rom_nomigrate(boot_rom, OBJECT(bmc), > "aspeed.boot_rom", > + memory_region_init_rom(boot_rom, OBJECT(bmc), "aspeed.boot_rom", > fl->size, &error_abort); > memory_region_add_subregion(get_system_memory(), FIRMWARE_ADDR, > boot_rom); >
