On 12 April 2018 at 18:01, Aaron Lindsay <alind...@codeaurora.org> wrote: > On Apr 12 17:49, Peter Maydell wrote: >> Do we make the guarantee that if we call the pre-change hook >> then we will definitely subsequently call the post-change hook? >> (ie does the PMU hook rely on that?) > > Yes, the PMU relies on the pre- and post- hooks being called in pairs > since they drive the state machine of sorts that exists in the variables > holding the counter values/deltas. And unless I've really screwed up the > implementation, I believe the change hooks in my patchset make that > guarantee.
Yes, I think I agree. We should document in the comment that this is a guarantee that we make. thanks -- PMM
