Thomas Huth <th...@redhat.com> writes: > On 10.04.2018 21:39, Alex Bennée wrote: >> The test mixes up 32bit and 64 bit code. It should probably be split >> into two distinct test cases. However for now just move it out of the >> way of the i386 build. >> >> Signed-off-by: Alex Bennée <alex.ben...@linaro.org> >> --- >> tests/tcg/{i386/test-i386-ssse3.c => x86_64/test-sse.c} | 6 ++---- >> 1 file changed, 2 insertions(+), 4 deletions(-) >> rename tests/tcg/{i386/test-i386-ssse3.c => x86_64/test-sse.c} (93%) > > Do we really want to have a separate x86_64 folder here? We also have > 64-bit code in hw/i386/ and target/i386/ so I don't think that we should > handle this differently for tests/tcg/i386 ? Wouldn't it be sufficient > to simply move this code to a separate file? ... just my 0.02 €
It's certainly simpler for the build rules to have a simple mapping from $(TARGET_NAME) to tests/tcg/FOO.... -- Alex Bennée