On 5 April 2018 at 02:22, Philippe Mathieu-Daudé <f4...@amsat.org> wrote: > If an user creates a RAM region smaller than TARGET_PAGE_SIZE, > this region will be handled as a subpage. > While the subpage behavior can be noticed by an experienced QEMU > developper, it might takes hours to a novice to figure it out. > To save time to novices, do not allow subpage creation via the > memory_region_init_ram_*() functions.
This commit message doesn't make it clear to me what actually goes wrong. Why doesn't the subpage mechanism do the right thing here? Also, a quick grep revealed at least one caller that's currently creating a less-than-a-page sized RAM block, in hw/pci-host/xilinx-pcie.c. We would need to change all the call sites that rely on creating small RAM blocks before we could make this throw an error. (Better still would be if we could make small lumps of RAM actually work.) thanks -- PMM
