On Wed, Apr 04, 2018 at 07:35:17PM -0700, no-re...@patchew.org wrote: > Hi, > > This series seems to have some coding style problems. See output below for > more information: > > Type: series > Message-id: 20180405022002.17809-1-da...@gibson.dropbear.id.au > Subject: [Qemu-devel] [PATCHv2 for-2.13 0/2] Helpers to obtain host page > sizes for guest RAM > > === TEST SCRIPT BEGIN === > #!/bin/bash > > BASE=base > n=1 > total=$(git log --oneline $BASE.. | wc -l) > failed=0 > > git config --local diff.renamelimit 0 > git config --local diff.renames True > git config --local diff.algorithm histogram > > commits="$(git log --format=%H --reverse $BASE..)" > for c in $commits; do > echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." > if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; > then > failed=1 > echo > fi > n=$((n+1)) > done > > exit $failed > === TEST SCRIPT END === > > Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 > From https://github.com/patchew-project/qemu > * [new tag] > patchew/20180405022002.17809-1-da...@gibson.dropbear.id.au -> > patchew/20180405022002.17809-1-da...@gibson.dropbear.id.au > Switched to a new branch 'test' > 3a2019a8ad Add host_memory_backend_pagesize() helper > d70b1b2b92 Make qemu_mempath_getpagesize() accept NULL > > === OUTPUT BEGIN === > Checking PATCH 1/2: Make qemu_mempath_getpagesize() accept NULL... > ERROR: braces {} are necessary for all arms of this statement > #96: FILE: util/mmap-alloc.c:56: > + } while (ret != 0 && errno == EINTR); > [...]
AFAICT this is a false positive where checkpatch is mistaking a do {}
while for a plain while loop.
> total: 1 errors, 0 warnings, 82 lines checked
>
> Your patch has style problems, please review. If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
>
> Checking PATCH 2/2: Add host_memory_backend_pagesize() helper...
> === OUTPUT END ===
>
> Test command exited with code: 1
>
>
> ---
> Email generated automatically by Patchew [http://patchew.org/].
> Please send your feedback to patchew-de...@redhat.com
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
