On Fri, 23 Mar 2018 16:11:53 -0500 Eric Blake <ebl...@redhat.com> wrote:
> On 03/12/2018 08:11 AM, Igor Mammedov wrote: [...] > > > preconfig state but allowed in all other states like they used > > to be. > > > > Within this patch allow following commands in preconfig state: > > qmp_capabilities > > query-qmp-schema > > query-commands > > query-status > > cont > > to allow qmp connection, basic introspection and moving to the next > > state. > > Looks like a reasonable list. Maybe also query-command-line-options > should be here? added > > > > PS: > > set-numa-node and query-hotpluggable-cpus will be enabled later in > > a separate patch. > > > > Signed-off-by: Igor Mammedov <imamm...@redhat.com> > > --- > > v4: > > * replaces complex "universal" approach > > "[PATCH v3 5/9] QAPI: allow to specify valid runstates per command" > > with a simpler new command flag "allowed-in-preconfig". > > (Eric Blake <ebl...@redhat.com>) > > Thanks; it looks a lot more maintainable now. However, you need to > rebase, now that 'allow-oob' has already landed. rebased [...] All other comments are addressed as well