On 2018年03月28日 14:03, Thomas Huth wrote:
On 28.03.2018 04:59, Jason Wang wrote:
On 2018年03月27日 21:16, Thomas Huth wrote:
# launch vde switch
vde_switch -F -sock /tmp/myswitch
# launch QEMU instance
-qemu-system-i386 linux.img -net nic -net vde,sock=/tmp/myswitch
+qemu-system-i386 linux.img -nic vde,sock=/tmp/myswitch
I think we should use -netdev here?
I've had that in the original version of this patch, but Paolo suggested
to use -nic instead since this is more "user-friendly":
https://lists.gnu.org/archive/html/qemu-devel/2018-02/msg05258.html
I personally don't mind whether we use "-netdev" or "-nic" in the
examples, as long as we finally get rid of "-net" there...
Right.
Please let me
know which way you prefer, so I can respin the patch again if necessary.
Thomas
But I think we should be consistent: in your patch some "-net" was
replaced by "-nic", but others were replaced by "-netdev".
These are *examples*, and I think it's good to give the users examples
for both ways of specifying a network connection. I'd really like to
avoid that people think that -nic is the only way of specifying such a
device, since you might not be able to configure all properties of the
NIC this way. On the other hand, -device + -netdev is really way more to
type, so we should also not only show this kind of examples. Thus a
mixture between both ways sounds like the right solution to me. But if
you disagree, let me know, then I can rework the patch again to either
only use -nic or only use -netdev in the examples.
Thomas
Ok. I get your point.
I will apply v3 as is.
Thanks
