On 23 March 2018 at 07:48, Andrew Jones <drjo...@redhat.com> wrote: > On Thu, Mar 22, 2018 at 04:23:18PM -0500, Wei Huang wrote: >> Instead of using "1.0" as the system version of SMBIOS, we should use >> mc->name for mach-virt machine type to be consistent other architectures. >> With this patch, "dmidecode -t 1" (e.g., "-M virt-2.12,accel=kvm") will >> show: >> >> Handle 0x0100, DMI type 1, 27 bytes >> System Information >> Manufacturer: QEMU >> Product Name: KVM Virtual Machine >> Version: virt-2.12 >> Serial Number: Not Specified >> ... >> >> instead of: >> >> Handle 0x0100, DMI type 1, 27 bytes >> System Information >> Manufacturer: QEMU >> Product Name: KVM Virtual Machine >> Version: 1.0 >> Serial Number: Not Specified >> ... >> >> For backward compatibility, we allow older machine types to keep "1.0" >> as the default system version. >> >> Signed-off-by: Wei Huang <w...@redhat.com>
> I don't think we need the compat code in this case. I used to pedantically > recommend compat code for all guest visible changes, but after speaking > with Igor about the policy for introducing compat code for ACPI table > updates, I learned that we can relax a bit on a case by case basis. In > this case I would recommend relaxing, but I won't insist, as the compat > code is indeed the safest way to go. > > Reviewed-by: Andrew Jones <drjo...@redhat.com> Applied to target-arm.next, thanks. -- PMM
