On 21/03/2018 04:25, Peter Xu wrote: > On Tue, Mar 20, 2018 at 04:18:57PM +0100, Paolo Bonzini wrote: >> This trips Coverity, which believes the subsequent qio_channel_create_watch >> can dereference a NULL pointer. In reality, tcp_chr_connect's callers >> all have s->ioc properly initialized, since they are all rooted at >> tcp_chr_new_client. >> >> Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> > > (maybe replacing with an assertion would be nicer? No big deal.)
It's already asserting, it just raises SIGSEGV instead of SIGABRT. :) Paolo
