On 03/20/2018 01:11 PM, Florian Larysch wrote:
On Tue, Mar 20, 2018 at 01:00:40PM -0500, Eric Blake wrote:
Here after the --- is a nice place to summarize how v3 differs from
v2, to save reviewers some time.
The triviality of the change didn't seem to warrant that, but in
retrospect, I realize that searching for the sole trivial change when
reviewing a patch is also (or even more of) a burden. I'll keep that in
mind for the future.
Also, if all that is wrong is a typo in the commit message, a
maintainer is often willing to fix that up without you having to
send a new revision
I interpreted your comment on the v2 as a request for me to fix that.
Sorry for the churn.
No problem - it's okay to learn as you go (we were all once new
contributors), and some things get easier the longer you've been on the
list to see the balance between saving yourself time and saving
reviewers/maintainers time.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
