On 03/20/2018 12:36 PM, Kevin Wolf wrote:
Signed-off-by: Kevin Wolf <kw...@redhat.com> --- tests/qemu-iotests/212 | 326 +++++++++++++++++++++++++++++++++++++++++++++ tests/qemu-iotests/212.out | 111 +++++++++++++++ tests/qemu-iotests/group | 1 + 3 files changed, 438 insertions(+) create mode 100755 tests/qemu-iotests/212 create mode 100644 tests/qemu-iotests/212.out
+echo +echo "=== Invalid sizes ===" +echo + +# TODO Negative image sizes aren't handled correctly, but this is a problem +# with QAPI's implementation of the 'size' type and affects other commands as +# well. Once this is fixed, we may want to add a test case here. + +# 1. Misaligned image size +# 2. 2^64 - 512 +# 3. 2^63 = 8 EB (qemu-img enforces image sizes less than this) +# 4. 2^63 - 512 (generally valid, but with the crypto header the file will +# exceed 63 bits)
Is this part of the comment stale copy-and-paste? There's no crypto header, and the real max is much smaller...
+# 5. 2^52 (512 bytes more than maximum image size) +
+echo +echo "=== Invalid cluster size ===" +echo +
-- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
