On 03/07/2018 06:03 PM, Nikunj A Dadhania wrote:
> Hi Richard,
>
> I was working to get TCG vector support for PowerPC[1]. Started with
> converting logical operations like vector AND/OR/XOR and compare
> instructions. Found some inconsistency during my testing on x86 laptop
> emulating PowerPC:
Great.
Well, the problem is that you cannot use TCG generic vectors and TCG global
variables to access the same memory.
Thus your first step must be to remove all references to cpu_avrh and cpu_avrl.
These can be replaced by translator helpers that perform an explicit
tcg_gen_ld_i64 or tcg_gen_st_i64 to the proper memory locations.
Only after that's done can you begin converting other references to use the
host vectors. Otherwise, the tcg optimizer will do Bad and Unpredictable
Things, which may well have produced the incorrect results that you saw.
I'll note that it's probably worth rearranging all of {fpr,vsr,avr} to the more
logical configuration presented by Power7 (?) such that it's one array of 64 x
128-bit registers.
r~
