On Thu, Mar 15, 2018 at 07:31:09PM +0100, Philippe Mathieu-Daudé wrote: > Hi Eduardo, > > On 03/13/2018 07:37 PM, Eduardo Habkost wrote: > > On Tue, Mar 13, 2018 at 06:29:10PM +0000, Peter Maydell wrote: > >> On 12 March 2018 at 22:34, Eduardo Habkost <ehabk...@redhat.com> wrote: > >>> The following changes since commit > >>> 6ceb1b51f05f9e1892d082960ed602dca7b6696e: > >>> > >>> Merge remote-tracking branch > >>> 'remotes/kraxel/tags/audio-20180312-pull-request' into staging > >>> (2018-03-12 16:14:37 +0000) > >>> > >>> are available in the Git repository at: > >>> > >>> git://github.com/ehabkost/qemu.git tags/machine-next-pull-request > >>> > >>> for you to fetch changes up to a82664f2f8b1ce2db90e644df01d7ca7845881a6: > >>> > >>> cpu: drop unnecessary NULL check and cpu_common_class_by_name() > >>> (2018-03-12 19:33:32 -0300) > >>> > >>> ---------------------------------------------------------------- > >>> Machine queue, 2018-03-12 > >>> > >> > >> Hi. It looks like this breaks bsd-user compilation: > >> > >> /root/qemu/bsd-user/main.c: In function 'main': > >> /root/qemu/bsd-user/main.c:905:5: warning: implicit declaration of > >> function 'create' [-Wimplicit-function-declaration] > >> cpu = create(cpu_type); > >> ^ > >> /root/qemu/bsd-user/main.c:905:5: warning: nested extern declaration > >> of 'create' [-Wnested-externs] > >> /root/qemu/bsd-user/main.c:905:9: warning: assignment makes pointer > >> from integer without a cast [enabled by default] > >> cpu = create(cpu_type); > >> ^ > >> > >> and then later it fails to link with > >> /root/qemu/bsd-user/main.c:905: undefined reference to `create' > > > > Oops, sorry. I don't have a BSD host handy right now, are you able to > > confirm > > if the new tag I pushed fixes it? > > You might try: > > $ make vm-test > vm-test: Test QEMU in preconfigured virtual machines > > vm-build-ubuntu.i386 - Build QEMU in ubuntu i386 VM > vm-build-freebsd - Build QEMU in FreeBSD VM > vm-build-netbsd - Build QEMU in NetBSD VM > vm-build-openbsd - Build QEMU in OpenBSD VM
This is awesome, thanks for the pointer! -- Eduardo
