Really glad to get a feedback so soon on my first attempt. Yes Thomas sir, I will apply these changes in my next patch. Now that this patch is already been implemented by Gerd sir in 2014 and it was not applied, should I consider finding some other task or should I improve this patch to get it merged or applied? Also as this was my first attempt, I selected the task mentioned in the wiki page https://wiki.qemu.org/BiteSizedTasks#Dead_code_removal As Paolo sir said, if this is too easy then can someone please suggest me any other task to work on so that I can create something useful to qemu??
Thanks, Aishwarya On Mon, Mar 12, 2018 at 6:33 PM, Peter Maydell <peter.mayd...@linaro.org> wrote: > On 12 March 2018 at 07:05, Gerd Hoffmann <kra...@redhat.com> wrote: > > Might be it actually is that easy. > > In fact looking through the list archives I see you actually > sent a patchset to do this for the sm501 device back in March > last year: > http://lists.gnu.org/archive/html/qemu-devel/2017-03/msg01172.html > > I think it didn't get applied mostly because it was on list > at the same time as a significant revamp of the sm501 device > code. So it probably won't apply cleanly to the current code, > but it looks like a good starting point for identifying what > the changes needed here are. > > thanks > -- PMM >
