Eduardo Habkost writes ("Re: [PATCH 03/11] xen: defer call to xen_restrict 
until just before os_setup_post"):
> On Thu, Mar 08, 2018 at 05:39:09PM +0000, Ian Jackson wrote:
> [...]
> > diff --git a/vl.c b/vl.c
> > +    xen_setup_post();
> 
> I don't think we should have accelerator-specific code in main(),
> if we already have accelerator classes that can abstract that
> out.  I suggest adding a AccelClass;:setup_post() method that can
> be called here.

I think I can do that.

Although, it is a bit disappointing to be given this feedback in v6 of
this series.  Did the right people not get CC'd on v5 in October ?

Ian.

Reply via email to