On 15.02.2018 15:38, Eric Blake wrote: > On 02/15/2018 05:06 AM, Thomas Huth wrote: >> Since commit 67a1de0d195a there is no space anymore between the >> version number and the parentheses when running configure with >> --with-pkgversion=foo : >> >> $ qemu-system-s390x --version >> QEMU emulator version 2.11.50(foo) >> >> But the space is included when building without that option >> when building from a git checkout: >> >> $ qemu-system-s390x --version >> QEMU emulator version 2.11.50 (v2.11.0-1494-gbec9c64-dirty) >> >> The same confusion exists with the "query-version" QMP command. >> Let's fix this by introducing a proper QEMU_FULL_VERSION definition >> that includes the space and parentheses, while the QEMU_PKGVERSION >> should just cleanly contain the package version string itself. >> Note that this also changes the behavior of the "query-version" QMP >> command (the space and parentheses are not included there anymore), >> but that's supposed to be OK since the strings there are not meant >> to be parsed by other tools. >> >> Fixes: 67a1de0d195a6185c39b436159c9ffc7720bf979 >> Buglink: https://bugs.launchpad.net/qemu/+bug/1673373 >> Signed-off-by: Thomas Huth <th...@redhat.com> >> --- > > I like it! > > Reviewed-by: Eric Blake <ebl...@redhat.com>
Ping! Paolo, could you maybe take this through your misc tree? Thomas
