Reviewed-by: Star Zeng <star.z...@intel.com> Thanks, Star -----Original Message----- From: Zhang, Chao B Sent: Thursday, March 8, 2018 8:35 AM To: marcandre.lur...@redhat.com; edk2-de...@lists.01.org Cc: pjo...@redhat.com; Yao, Jiewen <jiewen....@intel.com>; stef...@linux.vnet.ibm.com; ler...@redhat.com; qemu-devel@nongnu.org; javi...@redhat.com; Zeng, Star <star.z...@intel.com> Subject: RE: [PATCH v2 1/8] SecurityPkg: also clear HashInterfaceHob.SupportedHashMask
Reviewed-by: Chao Zhang<chao.b.zh...@intel.com> -----Original Message----- From: marcandre.lur...@redhat.com [mailto:marcandre.lur...@redhat.com] Sent: Wednesday, March 7, 2018 11:58 PM To: edk2-de...@lists.01.org Cc: pjo...@redhat.com; Yao, Jiewen <jiewen....@intel.com>; stef...@linux.vnet.ibm.com; ler...@redhat.com; qemu-devel@nongnu.org; javi...@redhat.com; Marc-André Lureau <marcandre.lur...@redhat.com>; Zhang, Chao B <chao.b.zh...@intel.com>; Zeng, Star <star.z...@intel.com> Subject: [PATCH v2 1/8] SecurityPkg: also clear HashInterfaceHob.SupportedHashMask From: Marc-André Lureau <marcandre.lur...@redhat.com> Commit 4cc2b63bd829426b05bad0d8952f1855a10d6ed7 fixed an out of bounds ZeroMem() call. However, as Laszlo Ersek pointed out, the intent was to clear all but the Identifier (to revert the effect of RegisterHashInterfaceLib()). For that, it should clear the SupportedHashMask too. Cc: Jiewen Yao <jiewen....@intel.com> Cc: Chao Zhang <chao.b.zh...@intel.com> Cc: Star Zeng <star.z...@intel.com> Cc: Laszlo Ersek <ler...@redhat.com> Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> --- .../Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterPei.c | 1 + 1 file changed, 1 insertion(+) diff --git a/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterPei.c b/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterPei.c index 361a4f6508a0..bf6e1336ee76 100644 --- a/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterPei.c +++ b/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRoute +++ rPei.c @@ -426,6 +426,7 @@ HashLibBaseCryptoRouterPeiConstructor ( // ZeroMem (&HashInterfaceHob->HashInterface, sizeof (HashInterfaceHob->HashInterface)); HashInterfaceHob->HashInterfaceCount = 0; + HashInterfaceHob->SupportedHashMask = 0; } // -- 2.16.2.346.g9779355e34
