On Tue, Mar 06, 2018 at 12:53:14PM -0500, Jason Baron wrote: > > > On 03/02/2018 12:54 PM, Michael S. Tsirkin wrote: > > On Thu, Mar 01, 2018 at 10:46:33PM -0500, Jason Baron wrote: > >> Pull in definitions for SPEED_UNKNOWN, DUPLEX_UNKNOWN, DUPLEX_HALF, > >> and DUPLEX_FULL. > >> > >> Signed-off-by: Jason Baron <jba...@akamai.com> > >> Cc: "Michael S. Tsirkin" <m...@redhat.com> > >> Cc: Jason Wang <jasow...@redhat.com> > >> Cc: virtio-...@lists.oasis-open.org > >> --- > >> include/net/eth.h | 7 +++++++ > >> 1 file changed, 7 insertions(+) > >> > >> diff --git a/include/net/eth.h b/include/net/eth.h > >> index 09054a5..9843678 100644 > >> --- a/include/net/eth.h > >> +++ b/include/net/eth.h > >> @@ -417,4 +417,11 @@ bool > >> eth_parse_ipv6_hdr(const struct iovec *pkt, int pkt_frags, > >> size_t ip6hdr_off, eth_ip6_hdr_info *info); > >> > >> +/* ethtool defines - from linux/ethtool.h */ > >> +#define SPEED_UNKNOWN -1 > >> + > >> +#define DUPLEX_HALF 0x00 > >> +#define DUPLEX_FULL 0x01 > >> +#define DUPLEX_UNKNOWN 0xff > >> + > >> #endif > > > > While that's not a lot, I think we should import linux/ethtool.h into > > include/standard-headers/linux/ using scripts/update-linux-headers.sh > > > > Ok, I had started down that path, by including > include/uapi/linux/ethtool.h but that resulted in a few other headers - > kernel.h, sysinfo.h. And so it seemed like a lot of headers for only a > few lines. But I will re-visit it... > > Thanks, > > -Jason
I don't know why is sysinfo there. Want to try sending a patch to drop it from linux/kernel.h? -- MST
