It eases code review, unit is explicit. Patch generated using:
$ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ and modified manually. Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- hw/block/tc58128.c | 2 +- hw/sh4/r2d.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/block/tc58128.c b/hw/block/tc58128.c index 1d9f7ee000..3e658d509f 100644 --- a/hw/block/tc58128.c +++ b/hw/block/tc58128.c @@ -26,7 +26,7 @@ typedef struct { static tc58128_dev tc58128_devs[2]; -#define FLASH_SIZE (16*1024*1024) +#define FLASH_SIZE (16 * M_BYTE) static void init_dev(tc58128_dev * dev, const char *filename) { diff --git a/hw/sh4/r2d.c b/hw/sh4/r2d.c index 458ed83297..720bd6ad04 100644 --- a/hw/sh4/r2d.c +++ b/hw/sh4/r2d.c @@ -292,7 +292,7 @@ static void r2d_init(MachineState *machine) dinfo = drive_get(IF_PFLASH, 0, 0); pflash_cfi02_register(0x0, NULL, "r2d.flash", FLASH_SIZE, dinfo ? blk_by_legacy_dinfo(dinfo) : NULL, - (16 * 1024), FLASH_SIZE >> 16, + 16 * K_BYTE, FLASH_SIZE >> 16, 1, 4, 0x0000, 0x0000, 0x0000, 0x0000, 0x555, 0x2aa, 0); -- 2.16.2