On 02/22/2018 01:11 PM, Peter Maydell wrote:
ERROR: line over 90 characters #54: FILE: hw/arm/mps2-tz.c:21: + * https://developer.arm.com/products/system-design/development-boards/fpga-prototyping-boards/mps2
Does anybody better with perl and more familiar with checkpatch's internals feel like tweaking it to suppress the over-long-line complaint for URLs ?
This one-liner appears to do the trick; I'll submit it formally in another thread:
diff --git i/scripts/checkpatch.pl w/scripts/checkpatch.pl index 1b4b812e28f..0d3f753c665 100755 --- i/scripts/checkpatch.pl +++ w/scripts/checkpatch.pl @@ -1447,9 +1447,10 @@ sub process { # check we are in a valid source file if not then ignore this hunk next if ($realfile !~ /$SrcFile/); -#90 column limit +#90 column limit; exempt URLs, if no other words on line if ($line =~ /^\+/ && !($line =~ /^\+\s*"[^"]*"\s*(?:\s*|,|\)\s*;)\s*$/) && + !($rawline =~ /^[^[:alnum:]]*https?:\S*$/) && $length > 80) { if ($length > 90) { -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org