On 17 February 2018 at 18:22, Richard Henderson <richard.hender...@linaro.org> wrote: > Signed-off-by: Richard Henderson <richard.hender...@linaro.org> > --- > target/arm/helper-sve.h | 21 +++++++++++++ > target/arm/helper.h | 1 + > target/arm/sve_helper.c | 77 > ++++++++++++++++++++++++++++++++++++++++++++++ > target/arm/translate-sve.c | 62 +++++++++++++++++++++++++++++++++++++ > target/arm/Makefile.objs | 2 +- > target/arm/sve.decode | 5 +++ > 6 files changed, 167 insertions(+), 1 deletion(-) > create mode 100644 target/arm/helper-sve.h > create mode 100644 target/arm/sve_helper.c > > diff --git a/target/arm/helper-sve.h b/target/arm/helper-sve.h > new file mode 100644 > index 0000000000..b6e91539ae > --- /dev/null > +++ b/target/arm/helper-sve.h > @@ -0,0 +1,21 @@ > +/* > + * AArch64 SVE specific helper definitions > + * > + * Copyright (c) 2018 Linaro, Ltd > + *
> +/* > + * ARM SVE Operations > + * > + * Copyright (c) 2018 Linaro I think we prefer "Linaro Limited" (cf https://wiki.linaro.org/Copyright) > diff --git a/target/arm/Makefile.objs b/target/arm/Makefile.objs > index 9934cf1d4d..452ac6f453 100644 > --- a/target/arm/Makefile.objs > +++ b/target/arm/Makefile.objs > @@ -19,4 +19,4 @@ target/arm/decode-sve.inc.c: > $(SRC_PATH)/target/arm/sve.decode $(DECODETREE) > "GEN", $(TARGET_DIR)$@) > > target/arm/translate-sve.o: target/arm/decode-sve.inc.c > -obj-$(TARGET_AARCH64) += translate-sve.o > +obj-$(TARGET_AARCH64) += translate-sve.o sve_helper.o > diff --git a/target/arm/sve.decode b/target/arm/sve.decode > index 0c6a7ba34d..7efaa8fe8e 100644 > --- a/target/arm/sve.decode > +++ b/target/arm/sve.decode > @@ -56,6 +56,11 @@ ORR_zzz 00000100 01 1 ..... 001 100 ..... > ..... @rd_rn_rm_e0 > EOR_zzz 00000100 10 1 ..... 001 100 ..... ..... > @rd_rn_rm_e0 > BIC_zzz 00000100 11 1 ..... 001 100 ..... ..... > @rd_rn_rm_e0 > > +### SVE Predicate Misc Group > + > +# SVE predicate test > +PTEST 00100101 01010000 11 pg:4 0 rn:4 00000 Shouldn't this be "0 1 01000011" instead of "01010000 11" (just a spacing change)? Bits 22 and 23 are op and S, so spacing it like that makes it easier to compare against the encoding diagram. Otherwise Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> thanks -- PMM
