Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20180219181922.21586-1-mark.cave-ayl...@ilande.co.uk
Subject: [Qemu-devel] [PATCH 00/11] macio: remove legacy macio_init() function
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag]
patchew/20180215212552.26997-1-marcandre.lur...@redhat.com ->
patchew/20180215212552.26997-1-marcandre.lur...@redhat.com
Switched to a new branch 'test'
b977ecc86a macio: remove macio_init() function
61db23bf85 macio: move setting of CUDA timebase frequency to
macio_common_realize()
c69bff3e41 mac_newworld: use object link to pass OpenPIC object to macio
0c0d0b3899 openpic: move OpenPIC state and related definitions to openpic.h
9e564cc429 mac_oldworld: use object link to pass heathrow PIC object to macio
effea2820a macio: move macio related structures and defines into separate
macio.h file
97c70c2c84 heathrow: change heathrow_pic_init() to return the heathrow device
71e75ff80c heathrow: convert to trace-events
408994eab6 heathrow: QOMify heathrow PIC
112e5b64e5 macio: move ESCC device within the macio device
076292acb3 macio: embed DBDMA device directly within macio
=== OUTPUT BEGIN ===
Checking PATCH 1/11: macio: embed DBDMA device directly within macio...
Checking PATCH 2/11: macio: move ESCC device within the macio device...
Checking PATCH 3/11: heathrow: QOMify heathrow PIC...
Checking PATCH 4/11: heathrow: convert to trace-events...
Checking PATCH 5/11: heathrow: change heathrow_pic_init() to return the
heathrow device...
Checking PATCH 6/11: macio: move macio related structures and defines into
separate macio.h file...
Checking PATCH 7/11: mac_oldworld: use object link to pass heathrow PIC object
to macio...
Checking PATCH 8/11: openpic: move OpenPIC state and related definitions to
openpic.h...
ERROR: "foo * bar" should be "foo *bar"
#249: FILE: include/hw/ppc/openpic.h:57:
+#define RAVEN_DBL_IRQ (RAVEN_IPI_IRQ + (RAVEN_MAX_CPU * RAVEN_MAX_IPI))
total: 1 errors, 0 warnings, 356 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 9/11: mac_newworld: use object link to pass OpenPIC object to
macio...
Checking PATCH 10/11: macio: move setting of CUDA timebase frequency to
macio_common_realize()...
Checking PATCH 11/11: macio: remove macio_init() function...
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-de...@freelists.org
