On 20 February 2018 at 15:28, Gerd Hoffmann <kra...@redhat.com> wrote: > The following changes since commit b487e2b2ff6e9fff8a45a9600d6de3a7bf82666a: > > Merge remote-tracking branch 'remotes/gkurz/tags/for-upstream' into staging > (2018-02-20 11:52:24 +0000) > > are available in the git repository at: > > git://git.kraxel.org/qemu tags/usb-20180220-pull-request > > for you to fetch changes up to 18c7310e9982b71d17e76648acfec0be42a57aea: > > usb-mtp: Advertise SendObjectInfo for write support (2018-02-20 16:06:56 > +0100) > > ---------------------------------------------------------------- > usb: Add write support to MTP. > > ---------------------------------------------------------------- > > Bandan Das (5): > usb-mtp: Add one more argument when building results > usb-mtp: print parent path in IN_IGNORED trace fn > usb-mtp: Support delete of mtp objects > usb-mtp: Introduce write support for MTP objects > usb-mtp: Advertise SendObjectInfo for write support
Hi. This fails to build on the BSDs, I'm afraid. FreeBSD: CC hw/usb/dev-mtp.o /root/qemu/hw/usb/dev-mtp.c:1558:8: warning: no previous prototype for function 'getumask' [-Wmissing-prototypes] mode_t getumask(void) ^ /root/qemu/hw/usb/dev-mtp.c:1664:9: warning: implicit declaration of function 'usb_mtp_object_lookup_name' is invalid in C99 [-Wimplicit-function-declaration] o = usb_mtp_object_lookup_name(p, filename, dataset->length); ^ /root/qemu/hw/usb/dev-mtp.c:1664:7: warning: incompatible integer to pointer conversion assigning to 'MTPObject *' (aka 'struct MTPObject *') from 'int' [-Wint-conversion] o = usb_mtp_object_lookup_name(p, filename, dataset->length); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 3 warnings generated. and then all the link steps fail with: ../hw/usb/dev-mtp.o: In function `usb_mtp_write_metadata': /root/qemu/hw/usb/dev-mtp.c:1664: undefined reference to `usb_mtp_object_lookup_name' NetBSD: CC hw/usb/dev-mtp.o /root/qemu/hw/usb/dev-mtp.c:1558:8: warning: no previous prototype for 'getumask' [-Wmissing-prototypes] mode_t getumask(void) ^ /root/qemu/hw/usb/dev-mtp.c: In function 'usb_mtp_write_metadata': /root/qemu/hw/usb/dev-mtp.c:1664:5: warning: implicit declaration of function 'usb_mtp_object_lookup_name' [-Wimplicit-function-declaration] o = usb_mtp_object_lookup_name(p, filename, dataset->length); ^ /root/qemu/hw/usb/dev-mtp.c:1664:5: warning: nested extern declaration of 'usb_mtp_object_lookup_name' [-Wnested-externs] /root/qemu/hw/usb/dev-mtp.c:1664:7: warning: assignment makes pointer from integer without a cast [enabled by default] o = usb_mtp_object_lookup_name(p, filename, dataset->length); ^ OpenBSD and OSX fail similarly. thanks -- PMM