On 16/02/2018 10:13, Peter Maydell wrote: > On 14 February 2018 at 12:11, Paolo Bonzini <pbonz...@redhat.com> wrote: >> On 14/02/2018 12:43, Zihan Yang wrote: >>> >>>> I'm not sure what is the advantage of this change. QEMU is more or less >>>> uniformly using QemuMutex and QemuCond. >>> >>> I see. QEMU uses some glib functions, like g_new, g_free, g_hash_table , >>> g_assert and g_poll, so I thought there was a trend for making more use >>> of glib. >>> I get the point now. >> >> There are some plans about using priority inheritance mutexes for >> QemuMutex. GLib does not support anymore pluggable thread functions, so >> we are stuck with our own implementation. > > Should we remove the entry > "Change QemuMutex and QemuCond to CompatGMutex and CompatGCond (these are > the same as GMutex and GCond, just with a different type). With this change, > qemu_mutex_init/qemu_cond_init becomes optional for global variables." > from https://wiki.qemu.org/Contribute/BiteSizedTasks then?
Yes, good idea. Paolo
