Re: [Qemu-devel] [PATCH v6 10/12] s390-ccw: read user input for boot index via the SCLP console

[Collin L. Walling]

On 02/16/2018 10:03 AM, David Hildenbrand wrote:

On 15.02.2018 23:54, Collin L. Walling wrote:

[...]
+
  static int get_boot_index(int entries)
  {
-    return 0; /* Implemented next patch */
+    int boot_index;
+    bool retry = false;
+    char tmp[5];
+
+    do {
+        boot_menu_prompt(retry);
+        boot_index = get_index();
+        retry = true;
+    } while (boot_index < 0 || boot_index >= entries);
+

Can you add a comment like

/*
  * We might still have pending SERVICE interrupts. Print something to
  * definitely clear it.
  */

I handle clearing the pending int in the next patch.

[...]

--
- Collin L Walling