On 02/15/2018 11:41 AM, Philippe Mathieu-Daudé wrote:
On 02/15/2018 02:34 PM, Daniel P. Berrangé wrote:
On Thu, Feb 15, 2018 at 02:23:06PM -0300, Philippe Mathieu-Daudé wrote:
Suggested-by: Eric Blake <ebl...@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org>
---
tests/docker/common.rc | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tests/docker/common.rc b/tests/docker/common.rc
index 7951555e3f..dd011cdf1e 100755
--- a/tests/docker/common.rc
+++ b/tests/docker/common.rc
@@ -30,7 +30,9 @@ build_qemu()
$@"
echo "Configure options:"
echo $config_opts
- $QEMU_SRC/configure $config_opts && make $MAKEFLAGS
+ $QEMU_SRC/configure $config_opts || \
+ (cat config.log && prep_fail "Failed to run 'configure'")
Is a subshell necessary; or can you get by with the simpler
{ cat && prep_fail "..."; }
+ make $MAKEFLAGS
}
Reviewed-by: Daniel P. Berrangé <berra...@redhat.com>
Slightly nicer than my patch thanks to the prep_fail addition.
Haha this was a funny experience of parallel programming :)
However your patch has a slightly nicer description!
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
