On 02/13/2018 04:10 PM, Emilio G. Cota wrote: > On Tue, Feb 13, 2018 at 14:10:20 -0800, Richard Henderson wrote: >> On 02/13/2018 01:55 PM, Emilio G. Cota wrote: >>> Are we planning to use BS_STOP in the future? I see it has no setters, >>> although we check for it in gen_intermediate_code: >> >> No, but the whole port should be converted to exec/translator.h, which >> defines >> DisasJumpType. Not something I'm going to require on initial submission >> until >> we've gotten most of the other targets cleaned up. > > I see. I've just done the conversion for v5: > https://github.com/cota/qemu/commits/riscv-v5-trloop > > Can you please take a look?
Looks ok. Watch your formatting, e.g { } on the same line. r~