> -----邮件原件-----
> 发件人: Philippe Mathieu-Daudé [mailto:philippe.mathieu.da...@gmail.com]
> 代表 Philippe Mathieu-Daudé
> 发送时间: 2018年2月13日 11:54
> 收件人: linzhecheng <linzhech...@huawei.com>; qemu-devel@nongnu.org
> 抄送: pbonz...@redhat.com; wangxin (U) <wangxinxin.w...@huawei.com>;
> lidonglin <lidong...@huawei.com>; m...@redhat.com
> 主题: Re: [Qemu-devel] [PATCH] vhost-user: fix memory leak
>
> Hi Linzhecheng,
>
> On 02/12/2018 11:53 PM, linzhecheng wrote:
> > fix memory leak
> >
> > Signed-off-by: linzhecheng <linzhech...@huawei.com>
> >
> > diff --git a/net/vhost-user.c b/net/vhost-user.c index
> > cb45512506..d024573e45 100644
> > --- a/net/vhost-user.c
> > +++ b/net/vhost-user.c
> > @@ -109,6 +109,7 @@ static int vhost_user_start(int queues,
> > NetClientState *ncs[], CharBackend *be)
> > err:
> > if (net) {
> > vhost_net_cleanup(net);
> > + g_free(net);
>
> I think this g_free() belongs to vhost_net_cleanup() in net/vhost_net.c:
I think your qemu version is out of date, g_free was moved from
vhost_net_cleanup in commit e6bcb1b
>
> void vhost_net_cleanup(struct vhost_net *net) {
> vhost_dev_cleanup(&net->dev);
> g_free(net);
> }
>
> Regards,
>
> Phil.
>
> > }
> > vhost_user_stop(i, ncs);
> > return -1;
> >
