On Mon, Feb 12, 2018 at 10:58:31AM +0100, Paolo Bonzini wrote:
> On 10/02/2018 00:07, John Snow wrote:
> >> + /* Early check to avoid creating target */
> >> + if (bdrv_op_is_blocked(bs, BLOCK_OP_TYPE_MIRROR_SOURCE, errp)) {
> >> + return;
> >> + }
> >> +
> >> aio_context = bdrv_get_aio_context(bs);
> >> aio_context_acquire(aio_context);
> >>
> >>
> > What's the implication of the temporarily-extant target node that it
> > needs to be avoided so strictly?
> >
>
> Creating a file on disk, that no one will ever remvoe. :)
Fortunately libvirt's SELinux policy will probably prevent QEMU creating
it in the first place :-)
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
