On 9 February 2018 at 17:07, Michael S. Tsirkin <m...@redhat.com> wrote: > On Fri, Feb 09, 2018 at 10:06:42AM +0000, Peter Maydell wrote: >> On 8 February 2018 at 19:08, Michael S. Tsirkin <m...@redhat.com> wrote: >> > The following changes since commit >> > 008a51bbb343972dd8cf09126da8c3b87f4e1c96: >> > >> > Merge remote-tracking branch 'remotes/famz/tags/staging-pull-request' >> > into staging (2018-02-08 14:31:51 +0000) >> > >> > are available in the git repository at: >> > >> > git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream >> > >> > for you to fetch changes up to f4ac9b2e04e8d98854a97bc473353207765aa9e7: >> > >> > virtio-balloon: include statistics of disk/file caches (2018-02-08 >> > 21:06:42 +0200) >> > >> > ---------------------------------------------------------------- >> > virtio,vhost,pci,pc: features, fixes and cleanups >> > >> > - a new vhost crypto device >> > - new stats in virtio balloon >> > - virtio eventfd rework for boot speedup >> > - vhost memory rework for boot speedup >> > - fixes and cleanups all over the place >> > >> > Signed-off-by: Michael S. Tsirkin <m...@redhat.com> >> > >> >> Hi. This has some format-string issues:
> Fixed up now, new hash d94c5ae38f25a6e77e07007dcd510b7203a687e8 This asserts in 'make check' for NetBSD, FreeBSD, OpenBSD, OSX: TEST: tests/device-introspect-test... (pid=19530) /aarch64/device/introspect/list: OK /aarch64/device/introspect/list-fields: OK /aarch64/device/introspect/none: OK /aarch64/device/introspect/abstract: OK /aarch64/device/introspect/concrete: ** ERROR:/root/qemu/qom/object.c:372:object_initialize_with_type: assertion failed: (type != NULL) Broken pipe FAIL GTester: last random seed: R02Sd4e2c04f6ac00d843a31ccac4de0d914 (pid=12686) /aarch64/device/introspect/abstract-interfaces: OK FAIL: tests/device-introspect-test (other archs fail too, aarch64 is just the first one we hit). This error is often "device A instantiates device B, but device B is conditionally compiled in and A is always compiled; so test fails trying to create device A on hosts where device B isn't built" I think. clang build on x86 fails to compile: /home/petmay01/linaro/qemu-for-merges/backends/cryptodev-vhost-user.c:86:16: error: address of array 's->vhost_crypto' will always evaluate to 'true' [-Werror,-Wpointer-bool-conversion] if (s->vhost_crypto) { ~~ ~~~^~~~~~~~~~~~ thanks -- PMM