Eric Blake <ebl...@redhat.com> writes: > Having two files in the tree both named qapi-schema.json just adds > confusion. Rename these files, and relocate them into the common > qapi/ subdirectory. Update all build rules that refer to the file > names, and adjust other documentation and comment references to > either track the new name or be rewritten so as to not mention > the file name. > > Maintainer-wise, this means that qapi/qga-schema.json continues > to belong to Michael as QGA maintainer, but now also notifies > Markus and Eric as QAPI maintainers, alongside all the other > QMP QAPI files, matching how other .json QAPI modules belong > to multiple maintainer blurbs. > > Signed-off-by: Eric Blake <ebl...@redhat.com> > --- > docs/devel/writing-qmp-commands.txt | 13 ++++++----- > docs/interop/qmp-intro.txt | 3 ++- > Makefile | 10 ++++---- > qga/qapi-schema.json => qapi/qga-schema.json | 0
This move is up to the QGA maintainer. My usual argument for keeping the schema in one place is weak for the QGA schema: it's maintained separately, and ususuall grepped separately, too. > qapi-schema.json => qapi/qmp-schema.json | 34 > ++++++++++++++-------------- While it was certainly created for QMP, it's now used for non-QMP stuff, too. Do we mind? > tpm.c | 2 +- > MAINTAINERS | 2 +- > 7 files changed, 33 insertions(+), 31 deletions(-) > rename qga/qapi-schema.json => qapi/qga-schema.json (100%) > rename qapi-schema.json => qapi/qmp-schema.json (99%)
