On Wed, Feb 07, 2018 at 09:52:25AM +0100, Igor Mammedov wrote: [...] > > * I suggest testing all CPU models in patch 02/25, but this > > shouldn't block the series. Can be a follow-up patch. > the goal of the test is that refactoring didn't regress > 'none' machine after following change in 23/25: > > @@ -24,9 +24,9 @@ static void machine_none_init(MachineState *mch) > { > CPUState *cpu = NULL; > > - /* Initialize CPU (if a model has been specified) */ > - if (mch->cpu_model) { > - cpu = cpu_init(mch->cpu_model); > + /* Initialize CPU (if user asked for it) */ > + if (mch->cpu_type) { > + cpu = cpu_create(mch->cpu_type); > > for that it's sufficient to probe one cpu model. > > We can do all cpus probing later if there will be need in it, > but that's not related to this series and would just waste > 'make check' time if it won't be doing something meaningful > with probed cpu.
Not making "make check" slow is a good argument, I agree. Extensive testing like testing all CPU models or all devices probably should be done in a separate (slower) test set. -- Eduardo