On Wed, Jan 31, 2018 at 9:03 AM, Philippe Mathieu-Daudé <f4...@amsat.org> wrote: > Hi Peter, Andrey. > > On 01/15/2018 10:36 PM, Andrey Smirnov wrote: >> Hi everyone, >> >> This v4 of the patch series containing the work that I've done in >> order to enable support for i.MX7 emulation in QEMU. >> >> *NOTE*: Patches 1 and 2 are provided for the sake of completness and >> are going to have to be adapted once Philippe's SD changes >> land in master. As such, they are NOT ready to be >> accepted/merged. > > Peter: > Since my series are taking longer, if this series is ready it is > probably easier to apply Andrey series first and I'll adapt my SDHCI > series after. > > Andrey: > I only plan to keep the sdhci.c file generic (dealing with quirks) and > split out the imx usdhci code, similar to this patch: > https://lists.gnu.org/archive/html/qemu-devel/2018-01/msg01265.html
Yes, I understand that, but I still am not clear how you propose dealing with the fact that i.MX specific read/write functions need to call similar functions from parent SDHC class. Are you planning on adding overridable read()/write() methods to SDHCICommonClass? Thanks, Andrey Smirnov