Marc-André Lureau <marcandre.lur...@redhat.com> writes:

> Add a new option to add user-specified #include lines in the generated
> headers. This will help to split a schema, where one generated header
> will depend on another.
>
> Fix some pycodestyle on the way.
>
> Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com>

With my alternative way to split up the generated monolith[*], required
generated headers should be included without the user's help.

We might conceivably need an ability to add includes for other purposes.
As far as I can tell, this is not the case in your series.

If we need the ability, then I'd rather use a directive in the schema
than a command line option.


[*] [PATCH RFC 00/21] Modularize generated QAPI code
Message-Id: <20180202130336.24719-1-arm...@redhat.com>

Reply via email to