On 01/30/2018 07:02 AM, Peter Maydell wrote: > + if (get_phys_addr(env, addr, MMU_DATA_STORE, mmu_idx, &physaddr, > + &attrs, &prot, &page_size, &fi, NULL)) {
Given that you know you're going to call this at least 8 times in a row, probably with all operations on the same page, it is worth querying the qemu tlb first, and when that fails but the lookup succeeds, installing the result into the tlb? I know we don't have a primitive for that within exec/cputlb.h, but perhaps we should. Perhaps a more generic form of probe_write... That said, this isn't wrong so Reviewed-by: Richard Henderson <richard.hender...@linaro.org> r~