On 03/02/18 11:11, no-re...@patchew.org wrote:
Hi,This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180203103727.26457-1-mark.cave-ayl...@ilande.co.uk Subject: [Qemu-devel] [PATCH 00/10] cuda: various fixes, and move 6522 to separate device === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BASE.. | wc -l) failed=0 git config --local diff.renamelimit 0 git config --local diff.renames True commits="$(git log --format=%H --reverse $BASE..)" for c in $commits; do echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then failed=1 echo fi n=$((n+1)) done exit $failed === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' 58c3da1206 cuda: convert to use the shared mos6522 device a110feb761 misc: introduce new mos6522 VIA device and enable it for ppc builds 00fdbc1124 cuda: factor out timebase-derived counter value and load time 8271348dd5 cuda: set timer 1 frequency property to CUDA_TIMER_FREQ 78543ffe92 cuda: minor cosmetic tidy-ups to get_next_irq_time() edafc73786 cuda: rename frequency property to tb_frequency 57d4dd6fc8 cuda: introduce CUDAState parameter to get_counter() 61fb181587 cuda: don't call cuda_update() when writing to ACR register 994240a346 cuda: don't allow writes to port output pins 5cbba0de9b cuda: do not use old_mmio accesses === OUTPUT BEGIN === Checking PATCH 1/10: cuda: do not use old_mmio accesses... Checking PATCH 2/10: cuda: don't allow writes to port output pins... Checking PATCH 3/10: cuda: don't call cuda_update() when writing to ACR register... Checking PATCH 4/10: cuda: introduce CUDAState parameter to get_counter()... Checking PATCH 5/10: cuda: rename frequency property to tb_frequency... Checking PATCH 6/10: cuda: minor cosmetic tidy-ups to get_next_irq_time()... Checking PATCH 7/10: cuda: set timer 1 frequency property to CUDA_TIMER_FREQ... Checking PATCH 8/10: cuda: factor out timebase-derived counter value and load time... Checking PATCH 9/10: misc: introduce new mos6522 VIA device and enable it for ppc builds... Checking PATCH 10/10: cuda: convert to use the shared mos6522 device... ERROR: do not use C99 // comments #31: FILE: hw/misc/macio/cuda.c:36: +//#define DEBUG_CUDA_PACKET total: 1 errors, 0 warnings, 897 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END ===
This is fine - it's old debug infrastructure in CUDA which is unrelated to this patchset.
ATB, Mark.
