On 2018-01-26 15:59, Alberto Garcia wrote: > expand_zero_clusters_in_l1() expands zero clusters as a necessary step > to downgrade qcow2 images to a version that doesn't support metadata > zero clusters. This function takes an L1 table (which may or may not > be active) and iterates over all its L2 tables looking for zero > clusters. > > Since we'll be loading L2 slices instead of full tables we need to add > an extra loop that iterates over all slices of each L2 table, and we > should also use the slice size when allocating the buffer used when > the L1 table is not active. > > This function doesn't need any additional changes so apart from that > this patch simply updates the variable name from l2_table to l2_slice. > > Finally, and since we have to touch the bdrv_read() / bdrv_write() > calls anyway, this patch takes the opportunity to replace them with > the byte-based bdrv_pread() / bdrv_pwrite(). > > Signed-off-by: Alberto Garcia <be...@igalia.com> > --- > block/qcow2-cluster.c | 52 > ++++++++++++++++++++++++++++----------------------- > 1 file changed, 29 insertions(+), 23 deletions(-)
Aside from the void * casts (and slice_size2 *cough* *cough*): Reviewed-by: Max Reitz <mre...@redhat.com>
signature.asc
Description: OpenPGP digital signature
