Hi Philipppe,
On 25.01.2018 12:22, Philippe Mathieu-Daudé wrote:
> Hi Richard, Helge,
>
> On 01/24/2018 08:26 PM, Richard Henderson wrote:
>> From: Helge Deller <del...@gmx.de>
>>
>> Now that we have the prerequisites in target/hppa/,
>> implement the hardware for a PA7100LC.
>>
>> This also enables build for hppa-softmmu.
>>
>> Signed-off-by: Helge Deller <del...@gmx.de>
>> [rth: Since it is all new code, squashed all branch development
>> withing hw/hppa/ to a single patch.]
>> Signed-off-by: Richard Henderson <richard.hender...@linaro.org>
>> ---
>> Makefile.objs | 1 +
>> hw/hppa/hppa_hardware.h | 40 +++
>> hw/hppa/hppa_sys.h | 24 ++
>> hw/hppa/dino.c | 518
>> +++++++++++++++++++++++++++++++++++++++
>> hw/hppa/machine.c | 246 ++++++++++++++++++-
>> hw/hppa/pci.c | 90 +++++++
>> default-configs/hppa-softmmu.mak | 14 ++
>> hw/hppa/Makefile.objs | 2 +-
>> hw/hppa/trace-events | 4 +
>> 9 files changed, 937 insertions(+), 2 deletions(-)
>> create mode 100644 hw/hppa/hppa_hardware.h
>> create mode 100644 hw/hppa/hppa_sys.h
>> create mode 100644 hw/hppa/dino.c
>> create mode 100644 hw/hppa/pci.c
>> create mode 100644 default-configs/hppa-softmmu.mak
>> create mode 100644 hw/hppa/trace-events
...
>> +static ISABus *hppa_isa_bus(void)
>> +{
>> + ISABus *isa_bus;
>> + qemu_irq *isa_irqs;
>> + MemoryRegion *isa_region;
>> +
>> + isa_region = g_new(MemoryRegion, 1);
>> + memory_region_init_io(isa_region, NULL, &hppa_pci_ignore_ops,
>> + NULL, "isa-io", 0x800);
>> + memory_region_add_subregion(get_system_memory(), IDE_HPA,
>> + isa_region);
>> +
>> + isa_bus = isa_bus_new(NULL, get_system_memory(), isa_region,
>> + &error_abort);
>> + isa_irqs = i8259_init(isa_bus,
>> + /* qemu_allocate_irq(dino_set_isa_irq, s, 0)); */
>
> What is that commented? circular dependency problem?
No actual problem.
It's a left-over from copy&pasting during the development phase.
We don't use and need ISA irqs yet.
I left it in in case I'm going to expand it, but basically it can go.
Helge
>> + NULL);
>> + isa_bus_irqs(isa_bus, isa_irqs);
>> +
>> + return isa_bus;
>> +}
