On Thu, Jan 18, 2018 at 4:32 AM, Philippe Mathieu-Daudé <f4...@amsat.org> wrote:
> now than the Exynos4210 uses the 'capareg-reserved' property,
> we can safely report missing capabilities as error, since
> capabilities will only get changed once new SDHCI models
> are added.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org>
Reviewed-by: Alistair Francis <alistair.fran...@xilinx.com>
Alistair
> ---
> hw/sd/sdhci.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c
> index 7799382e89..07a7ebcc1e 100644
> --- a/hw/sd/sdhci.c
> +++ b/hw/sd/sdhci.c
> @@ -23,7 +23,6 @@
> */
>
> #include "qemu/osdep.h"
> -#include "qemu/error-report.h"
> #include "qapi/error.h"
> #include "hw/hw.h"
> #include "sysemu/block-backend.h"
> @@ -1208,7 +1207,8 @@ static void sdhci_init_readonly_registers(SDHCIState
> *s, Error **errp)
> } else {
> capab = s->capareg & ~capab;
> if (capab) {
> - warn_report("SDHCI: missing capability mask: 0x%" PRIx64, capab);
> + error_setg(errp, "missing capability mask: 0x%" PRIx64, capab);
> + return;
> }
> }
> }
> --
> 2.15.1
>
>
