> -----Original Message----- > From: Zhoujian (jay) > Sent: Wednesday, January 17, 2018 1:01 PM > To: Michael S. Tsirkin > Cc: pa...@linux.vnet.ibm.com; Huangweidong (C); xin.z...@intel.com; > qemu-devel@nongnu.org; Gonglei (Arei); roy.fan.zh...@intel.com; > stefa...@redhat.com; pbonz...@redhat.com; longpeng > Subject: RE: [Qemu-devel] [PATCH v3 1/4] cryptodev: add vhost-user as a new > cryptodev backend > > > -----Original Message----- > > From: Qemu-devel [mailto:qemu-devel- > > bounces+jianjay.zhou=huawei....@nongnu.org] On Behalf Of Michael S. > Tsirkin > > Sent: Wednesday, January 17, 2018 12:41 AM > > To: Zhoujian (jay) <jianjay.z...@huawei.com> > > Cc: pa...@linux.vnet.ibm.com; Huangweidong (C) > <weidong.hu...@huawei.com>; > > xin.z...@intel.com; qemu-devel@nongnu.org; Gonglei (Arei) > > <arei.gong...@huawei.com>; roy.fan.zh...@intel.com; > stefa...@redhat.com; > > pbonz...@redhat.com; longpeng <longpe...@huawei.com> > > Subject: Re: [Qemu-devel] [PATCH v3 1/4] cryptodev: add vhost-user as a new > > cryptodev backend > > > > On Tue, Jan 16, 2018 at 10:06:50PM +0800, Jay Zhou wrote: > > > From: Gonglei <arei.gong...@huawei.com> > > > > > > Usage: > > > -chardev socket,id=charcrypto0,path=/path/to/your/socket > > > -object cryptodev-vhost-user,id=cryptodev0,chardev=charcrypto0 > > > -device virtio-crypto-pci,id=crypto0,cryptodev=cryptodev0 > > > > > > Signed-off-by: Gonglei <arei.gong...@huawei.com> > > > Signed-off-by: Longpeng(Mike) <longpe...@huawei.com> > > > Signed-off-by: Jay Zhou <jianjay.z...@huawei.com> > > > --- > > > backends/Makefile.objs | 4 + > > > backends/cryptodev-vhost-user.c | 333 > > +++++++++++++++++++++++++++++++++++++++ > > > backends/cryptodev-vhost.c | 73 +++++++++ > > > include/sysemu/cryptodev-vhost.h | 154 ++++++++++++++++++ > > > qemu-options.hx | 21 +++ > > > vl.c | 4 + > > > 6 files changed, 589 insertions(+) > > > create mode 100644 backends/cryptodev-vhost-user.c create mode > > > 100644 backends/cryptodev-vhost.c create mode 100644 > > > include/sysemu/cryptodev-vhost.h > > > > > > diff --git a/backends/Makefile.objs b/backends/Makefile.objs index > > > 0400799..9e1fb76 100644 > > > --- a/backends/Makefile.objs > > > +++ b/backends/Makefile.objs > > > @@ -8,3 +8,7 @@ common-obj-$(CONFIG_LINUX) += hostmem-file.o > > > > > > common-obj-y += cryptodev.o > > > common-obj-y += cryptodev-builtin.o > > > + > > > +ifeq ($(CONFIG_VIRTIO),y) > > > +common-obj-$(CONFIG_LINUX) += cryptodev-vhost.o > > > +cryptodev-vhost-user.o endif > > > > Shouldn't this depend on CONFIG_VHOST_USER? > > Yes, you're right. Will fix it soon. > Hi Michael,
Can we apply this patch set firstly and then fix it on the top with other comments? Thanks, -Gonglei
