On 01/12/2018 08:49 PM, Philippe Mathieu-Daudé wrote:
Hi, This series is to be clearer about which upstream version we are using. All "FROM distrib:latest" entries have now been removed and replaced by explicit "FROM distrib:version" ones. To keep backward compatibility, a warning is displayed to the user, suggesting which correct base image to use. To be consistent, we remove the deprecated images of the "make docker" output.
Changing image names when a new release comes out is not maintainable for Fedora and Ubuntu because of the fast pace. Therefore I prefer Paolo's simple patch.
Maybe you can somehow create an alias in Makefile to point "fedora" to "fedora${last_release_num}", and update it when adding a new release. But still I don't think keeping more than one fedora dockerfiles is very useful.
In principle, we use Debian, CentOS and ubuntu-lts to cover long living releases and {ubuntu,fedora}:latest to cover cutting edge releases. Spending effort on tests is better than adding more versions, IMO.
Thanks, Fam
Regards, Phil. Philippe Mathieu-Daudé (7): docker: sort images list displayed by 'make docker' docker: do not display deprecated images in 'make docker' help docker: add the Ubuntu Trusty base image docker: do not use Trusty APT source in Xenial docker: warn users to use ubuntu16.04 for the LTS Xenial image docker: add the Fedora 27 base image docker: warn users to use newer fedora25/fedora27 base image tests/docker/Makefile.include | 5 ++++- tests/docker/dockerfiles/fedora.docker | 29 ++++++++++++----------------- tests/docker/dockerfiles/fedora25.docker | 18 ++++++++++++++++++ tests/docker/dockerfiles/fedora27.docker | 18 ++++++++++++++++++ tests/docker/dockerfiles/ubuntu.docker | 28 ++++++++++------------------ tests/docker/dockerfiles/ubuntu14.04.docker | 17 +++++++++++++++++ tests/docker/dockerfiles/ubuntu16.04.docker | 16 ++++++++++++++++ 7 files changed, 95 insertions(+), 36 deletions(-) create mode 100644 tests/docker/dockerfiles/fedora25.docker create mode 100644 tests/docker/dockerfiles/fedora27.docker create mode 100644 tests/docker/dockerfiles/ubuntu14.04.docker create mode 100644 tests/docker/dockerfiles/ubuntu16.04.docker
