Le 16/01/2018 à 16:54, Richard Henderson a écrit : > On 01/16/2018 06:13 AM, Laurent Vivier wrote: >>> There is no reason to read the elf header twice -- e_flags has already been >>> stored in the struct image_info. >> >> When we set cpu_model, image_info is not initialized. >> Do you propose to move cpu_init() after loader_exec()? > > Sure.
After checking, I think we can't move cpu_init() after loader_exec(): load_elf_binary() needs to fill AT_HWCAP and in the case of i386 it depends on cpu->env.features[FEAT_1_EDX] that comes from the cpu model. Thanks, Laurent
