On 01/16/2018 07:42 AM, Daniel P. Berrange wrote: > Python2 did not validate locale correctness when reading input data, so > would happily read UTF-8 data in non-UTF-8 locales. Python3 is strict so > if you try to read UTF-8 data in the C locale, it will raise an error > for any UTF-8 bytes that aren't representable in 7-bit ascii encoding. > e.g. >
> > Many distros support a new C.UTF-8 locale that is like the C locale, > but with UTF-8 instead of 7-bit ASCII. That is not entirely portable > though. This patch thus sets the LANG to "C", but overrides LC_CTYPE > to be en_US.UTF-8 locale. This gets us pretty close to C.UTF-8, but > in a way that should be portable to everywhere QEMU builds. > > This patch only forces UTF-8 for QAPI scripts, since that is the one > showing the immediate error under Python3 with C locale, but potentially > we ought to force this for all python scripts used in the build process. > > Signed-off-by: Daniel P. Berrange <berra...@redhat.com> > --- > Makefile | 22 ++++++++++++---------- > 1 file changed, 12 insertions(+), 10 deletions(-) Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
