On 01/15/2018 10:51 AM, Peter Maydell wrote: > On 13 January 2018 at 05:07, Philippe Mathieu-Daudé <f4...@amsat.org> wrote: >> Since v6: >> - addressed Peter reviews >> - do not use an unique Property[] for both sysbus/pci >> Peter didn't recommend me to use the qdev_property_add_static() API since >> it is only used by the ARM cpus and may be due for removal, however I >> found >> it cleaner. > > Your cover letter says this but patches 3 and 14 in the v7 you sent > to the list use qdev_property_add_static(). Did you send the wrong > version of the code?
The cover is not clear, I'll try to reword it: ''' Peter recommended me to NON use the qdev_property_add_static() API since it is only used by the ARM cpus and may be due for removal. However I found using qdev_property_add_static() cleaner, and sent this series with using the not recommended qdev_property_add_static(). ''' Is it possible to share properties without using qdev_property_add_static()? Thanks, Phil.
