Hi Igor, > -----Original Message----- > From: Igor Mammedov [mailto:imamm...@redhat.com] > Sent: Thursday, January 11, 2018 9:05 PM > To: Zhoujian (jay) <jianjay.z...@huawei.com> > Cc: qemu-devel@nongnu.org; m...@redhat.com; Huangweidong (C) > <weidong.hu...@huawei.com>; wangxin (U) <wangxinxin.w...@huawei.com>; Gonglei > (Arei) <arei.gong...@huawei.com>; Liuzhe (Ahriy, Euler) <liuzh...@huawei.com> > Subject: Re: [PATCH v5 0/4] vhost: two fixes and used_memslots refactoring > > On Wed, 10 Jan 2018 00:39:02 +0800 > Jay Zhou <jianjay.z...@huawei.com> wrote: > > Jay, > considering how non trivial touched code is, would you mind first adding > 'make check' testcases for success/failure paths that you are touching? > It would help with merging and ensure that future changes to vhost won't > break memslots handling.
Will look into the testcases. Maybe it would take some time since I'm not very familiar with them. Regards, Jay > > > v4 -> v5: > > Making the followed up device_add to fall back to userspace > > virtio when netdev_add fails if vhost force flag does not set. > > > > Jay Zhou (4): > > vhost: remove assertion to prevent crash > > tap: do not close fd if only vhost failed to initialize > > vhost: fix memslot limit check > > vhost: used_memslots refactoring > > > > hw/virtio/vhost-backend.c | 15 +++++++- > > hw/virtio/vhost-user.c | 74 +++++++++++++++++++++++++++-------- > ---- > > hw/virtio/vhost.c | 30 +++++++++------- > > include/hw/virtio/vhost-backend.h | 6 ++-- > > net/tap.c | 25 +++++++++---- > > 5 files changed, 104 insertions(+), 46 deletions(-) > > > > -- > > 1.8.3.1 > > > >
