On 12/19/2017 02:45 AM, Peter Xu wrote: Grammar in the subject:
"allow to $VERB" is not idiomatic English; correct is either "allow
${VERB}ing" or "allow $SUBJECT to $VERB". Concretely, s/to use/using/
> For each Monitor, add one field "use_io_thr" to show whether it will be
> using the dedicated monitor IO thread to handle input/output. When set,
> monitor IO parsing work will be offloaded to dedicated monitor IO
s/to/to the/
> thread, rather than the original main loop thread.
>
> This only works for QMP. HMP will always be run on main loop thread.
s/on/on the/
>
> Currently we're still keeping use_io_thr to off always. Will turn it on
s/to off/off/
> later at some point.
>
> One thing to mention is that we cannot set use_io_thr for every QMP
> monitors. The problem is that MUXed typed chardevs may not work well
s/monitors/monitor/
> with it now. When MUX is used, frontend of chardev can be the monitor
> plus something else. The only thing we know would be safe to be run
> outside main thread so far is the monitor frontend. All the rest of the
> frontends should still be run in main thread only.
>
> Signed-off-by: Peter Xu <pet...@redhat.com>
> ---
> monitor.c | 41 ++++++++++++++++++++++++++++++++---------
> 1 file changed, 32 insertions(+), 9 deletions(-)
>
I have nothing to add on the code review, but it looks like Stefan had
valid comments that need addressing.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
