On 12/15/2017 09:31 AM, Peter Maydell wrote: > I suspect this codepath has never been tested. There's another > bug in moxie_cpu_handle_mmu_fault() where it will call > tlb_set_page() even in the "mmu lookup missed, we're > going to throw an exception" codepath.
Ah, didn't notice that one, but yes. > Is moxie even worth bothering to keep in QEMU? As far as I can tell: > * the only changes to target/moxie since the target was added in > 2013 have been generic cross-tree changes and cleanups and > minor bugs found by static analysis etc > * the last commit signed-off-by the moxie maintainer was > in March 2013 > * last email to qemu-devel by the maintainer was December 2013 > * as far as I can tell nobody's ever reported a bug to us, > which is suggestive that it has no users > > This target is costing us maintenance effort -- is it actually > useful to anybody ? I doubt it. I'd be ok removing it. r~
