On 18/12/2017 16:30, Cornelia Huck wrote:
> On Mon, 18 Dec 2017 16:10:50 +0100
> Laurent Vivier <lviv...@redhat.com> wrote:
>
>> On 16/12/2017 18:41, Stefan Berger wrote:
>>> From: Marc-André Lureau <marcandre.lur...@redhat.com>
>>>
>>> A property to lookup a tpm backend.
>>>
>>> Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com>
>>> Reviewed-by: Stefan Berger <stef...@linux.vnet.ibm.com>
>>> Signed-off-by: Stefan Berger <stef...@linux.vnet.ibm.com>
>>> ---
>>> hw/core/qdev-properties-system.c | 64
>>> ++++++++++++++++++++++++++++++++++++++++
>>> include/hw/qdev-properties.h | 3 ++
>>> 2 files changed, 67 insertions(+)
>>
>> This one breaks my build:
>>
>> ...
>> LINK ppc64-softmmu/qemu-system-ppc64
>> ../hw/core/qdev-properties-system.o: In function `release_tpm':
>> /home/lvivier/qemu/hw/core/qdev-properties-system.c:291: undefined
>> reference to `tpm_backend_reset'
>> ../hw/core/qdev-properties-system.o: In function `set_tpm':
>> /home/lvivier/qemu/hw/core/qdev-properties-system.c:274: undefined
>> reference to `qemu_find_tpm_be'
>> /home/lvivier/qemu/hw/core/qdev-properties-system.c:278: undefined
>> reference to `tpm_backend_init'
>> collect2: error: ld returned 1 exit status
>>
>> The following #ifdef fixes the problem for me:
>>
>> diff --git a/hw/core/qdev-properties-system.c
>> b/hw/core/qdev-properties-system.c
>> index c173646..b6eca3b 100644
>> --- a/hw/core/qdev-properties-system.c
>> +++ b/hw/core/qdev-properties-system.c
>> @@ -239,6 +239,7 @@ const PropertyInfo qdev_prop_chr = {
>>
>> /* --- character device --- */
>>
>> +#if defined(CONFIG_TPM)
>> static void get_tpm(Object *obj, Visitor *v, const char *name, void
>> *opaque,
>> Error **errp)
>> {
>> @@ -299,6 +300,7 @@ const PropertyInfo qdev_prop_tpm = {
>> .set = set_tpm,
>> .release = release_tpm,
>> };
>> +#endif
>>
>> /* --- netdev device --- */
>> static void get_netdev(Object *obj, Visitor *v, const char *name,
>>
>> Thanks,
>> Laurent
>>
>
> This seems to be a popular error today :)
>
> https://lists.nongnu.org/archive/html/qemu-devel/2017-12/msg03511.html
>
Thank you Cornelia, I was hoping someone already posted a patch.
You win ;)
Laurent
